REGR: Fix IntervalIndex.map when result is object dtype #31232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Regression
jschendel
commented
Jan 23, 2020
| @@ -164,22 +164,6 @@ def __contains__(self, key: Any) -> bool: | |||
| is_scalar(res) or isinstance(res, slice) or (is_list_like(res) and len(res)) | |||
| ) | |||
|
|
|||
| # Try to run function on index first, and then on elements of index | |||
| # Especially important for group-by functionality | |||
| def map(self, mapper, na_action=None): | |||
There was a problem hiding this comment.
@jbrockmendel : do you have any issues with moving the map definition in DatetimeIndexOpsMixin down to ExtensionIndex so it's shared with IntervalIndex? This seems to more gracefully handle index specific attributes (e.g. freq for DTI, closed for II) than Index.map.
There was a problem hiding this comment.
definitely on board with this if we can use this for the general case
| @@ -808,6 +808,13 @@ def test_map_dictlike(self, mapper): | |||
| result = index.map(mapper(expected, index)) | |||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
| def test_map_str(self): | |||
There was a problem hiding this comment.
Decided to write a common test for index.map(str) that shared across all index types since it didn't look like we were generically testing something similar. Can remove this an write and IntervalIndex specific test if that'd be preferred.
TomAugspurger
approved these changes
Jan 23, 2020
|
thanks @jschendel |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 23, 2020
… is object dtype
TomAugspurger
pushed a commit
that referenced
this pull request
Jan 23, 2020
… dtype (#31246) Co-authored-by: Jeremy Schendel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffNo whatnew since this is a regression.